Refactor turbomind attention by precomputing cos/sin #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
changed the title
lvhan028
reviewed
Nov 27, 2024
| @@ -81,6 +83,11 @@ void UnifiedDecoder<T>::forwardSelfAttn(T* attn_io, | |||
| inputs.insert("h_cu_q_len", {MEMORY_CPU, TYPE_INT32, {batch_size + 1}, h_cu_q_len_}); | |||
| inputs.insert("h_cu_k_len", {MEMORY_CPU, TYPE_INT32, {batch_size + 1}, h_cu_k_len_}); | |||
|
|
|||
| if (rotary_emb_) { | |||
There was a problem hiding this comment.
any case that rotary_emb_ a nullptr?
lvhan028
reviewed
Dec 2, 2024
| @@ -59,22 +59,45 @@ struct MoeParam { | |||
| std::vector<int> expert_num; | |||
| }; | |||
|
|
|||
| enum class RotaryScalingType | |||
There was a problem hiding this comment.
RotaryScalingType -> RopeType
lvhan028
reviewed
Dec 2, 2024
|
|
||
| struct InnerYarnRopeParam { | ||
| float attention_factor; | ||
| float yarn_ramp_inv_factor_div_2; |
There was a problem hiding this comment.
I think we can remove the prefix "yarn_"
lvhan028
reviewed
Dec 2, 2024
| }; | ||
|
|
||
| struct InnerLlama3RopeParam { | ||
| float llama3_inv_scaling_factor; |
There was a problem hiding this comment.
the prefix "llama3_" can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Calculate cos/sin in advance and reduce the parameters of the prefill/decode kernel